Merged
Conversation
d6b0eed to
ec926ae
Compare
2 issues:
- Some local variables in pnut-exe were called
`next`, which is a reserved word in AWK.
- The `_write` runtime function was implemented
in a way that prevented null bytes from being
written correctly.
5b5b370 to
1d4a542
Compare
ff95232 to
54a10f7
Compare
54a10f7 to
902e305
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Why stop at POSIX shell?
This PR adds a new pnut variant: pnut-awk. AWK is a much better compilation target (local variables, built-in arrays) than the shell, making the
pnut-awk.awkseed script smaller thanpnut-sh.sh(4225 vs 6131 lines of code) and much faster to bootstrap (less than 5 seconds on the awk implementations I tested (gawk, nawk, mawk). AWK has similar characteristics (multiple implementation, stable, defined by a standard) as POSIX shell that makes them good starting points for reproducible builds.I haven't played too much with it, I'm sure the current implementation uses extended AWK features. Some AWK implementations need to be invoked with
--posixto make them conform to POSIX AWK.Inspired by @cosinusoidally's cjsawk presentation :)